chore: pass options to tracer start #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #775 +/- ##
==========================================
- Coverage 60.47% 60.46% -0.02%
==========================================
Files 245 245
Lines 31133 31133
==========================================
- Hits 18829 18825 -4
- Misses 10629 10633 +4
Partials 1675 1675
|
hsanjuan
approved these changes
Jan 3, 2025
Dreamacro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was reading the code, I found the problem of missing parameters. Maybe
boxoneeds a static checking tool likegolangci-lintto standardize the code?I can also change this pr to add a static checking tool and fix the lint if needed